tablet/atlantafx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE when the Popover owner is not added to the scene #49

Browse Source
This commit is contained in:
mkpaz 2023-05-30 16:00:46 +04:00
parent 083ac8a0a7
commit 3860c9c63d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
base/src/main/java/atlantafx/base/controls/Popover.java
View File

@ -29,7 +29,6 @@
package atlantafx.base.controls; package atlantafx.base.controls;
import static java.util.Objects.requireNonNull;
import static javafx.scene.input.MouseEvent.MOUSE_CLICKED; import static javafx.scene.input.MouseEvent.MOUSE_CLICKED;
import java.util.Objects; import java.util.Objects;
@ -252,9 +251,14 @@ public class Popover extends PopupControl {
* overlap with the owner node (positive values are recommended) * overlap with the owner node (positive values are recommended)
*/ */
public final void show(Node owner, double offset) { public final void show(Node owner, double offset) {
requireNonNull(owner); Objects.requireNonNull(owner, "Owner node cannot be null!");
Bounds bounds = owner.localToScreen(owner.getBoundsInLocal()); Bounds bounds = owner.localToScreen(owner.getBoundsInLocal());
if (bounds == null) {
throw new IllegalStateException(
"The owner node is not added to the scene. It cannot be used as a popover anchor."
);
}
switch (getArrowLocation()) { switch (getArrowLocation()) {
case BOTTOM_CENTER, BOTTOM_LEFT, BOTTOM_RIGHT -> show( case BOTTOM_CENTER, BOTTOM_LEFT, BOTTOM_RIGHT -> show(