tablet/gorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use WriteByte for single byte operations (#5167)

Browse Source 
Co-authored-by: Mikhail Faraponov <mikefaraponov@Mikhails-MacBook-Pro.local>
This commit is contained in:
Mikhail Faraponov 2022-03-17 16:54:30 +02:00 committed by GitHub
parent f3e2da5ba3
commit 2990790fbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clause/limit.go
View File

@ -21,7 +21,7 @@ func (limit Limit) Build(builder Builder) {
} }
if limit.Offset > 0 { if limit.Offset > 0 {
if limit.Limit > 0 { if limit.Limit > 0 {
builder.WriteString(" ") builder.WriteByte(' ')
} }
builder.WriteString("OFFSET ") builder.WriteString("OFFSET ")
builder.WriteString(strconv.Itoa(limit.Offset)) builder.WriteString(strconv.Itoa(limit.Offset))

4
clause/where.go
View File

@ -72,9 +72,9 @@ func buildExprs(exprs []Expression, builder Builder, joinCond string) {
} }
if wrapInParentheses { if wrapInParentheses {
builder.WriteString(`(`) builder.WriteByte('(')
expr.Build(builder) expr.Build(builder)
builder.WriteString(`)`) builder.WriteByte(')')
wrapInParentheses = false wrapInParentheses = false
} else { } else {
expr.Build(builder) expr.Build(builder)

4
statement.go
View File

@ -130,7 +130,7 @@ func (stmt *Statement) QuoteTo(writer clause.Writer, field interface{}) {
writer.WriteByte('(') writer.WriteByte('(')
for idx, d := range v { for idx, d := range v {
if idx > 0 { if idx > 0 {
writer.WriteString(",") writer.WriteByte(',')
} }
stmt.QuoteTo(writer, d) stmt.QuoteTo(writer, d)
} }
@ -143,7 +143,7 @@ func (stmt *Statement) QuoteTo(writer clause.Writer, field interface{}) {
writer.WriteByte('(') writer.WriteByte('(')
for idx, d := range v { for idx, d := range v {
if idx > 0 { if idx > 0 {
writer.WriteString(",") writer.WriteByte(',')
} }
stmt.DB.Dialector.QuoteTo(writer, d) stmt.DB.Dialector.QuoteTo(writer, d)
} }

4
utils/tests/dummy_dialecter.go
View File

@ -49,7 +49,7 @@ func (DummyDialector) QuoteTo(writer clause.Writer, str string) {
shiftDelimiter = 0 shiftDelimiter = 0
underQuoted = false underQuoted = false
continuousBacktick = 0 continuousBacktick = 0
writer.WriteString("`") writer.WriteByte('`')
} }
writer.WriteByte(v) writer.WriteByte(v)
continue continue
@ -74,7 +74,7 @@ func (DummyDialector) QuoteTo(writer clause.Writer, str string) {
if continuousBacktick > 0 && !selfQuoted { if continuousBacktick > 0 && !selfQuoted {
writer.WriteString("``") writer.WriteString("``")
} }
writer.WriteString("`") writer.WriteByte('`')
} }
func (DummyDialector) Explain(sql string, vars ...interface{}) string { func (DummyDialector) Explain(sql string, vars ...interface{}) string {