Fix uninitialized Valuer return time.Time, close #3214

schema/field.go

@@ -213,6 +213,8 @@ func (schema *Schema) ParseField(fieldStruct reflect.StructField) *Field {
 	case reflect.Struct:
 		if _, ok := fieldValue.Interface().(*time.Time); ok {
 			field.DataType = Time
+		} else if fieldValue.Type().ConvertibleTo(reflect.TypeOf(time.Time{})) {
+			field.DataType = Time
 		} else if fieldValue.Type().ConvertibleTo(reflect.TypeOf(&time.Time{})) {
 			field.DataType = Time
 		}

tests/scanner_valuer_test.go

@@ -124,20 +124,21 @@ func TestInvalidValuer(t *testing.T) {
 
 type ScannerValuerStruct struct {
 	gorm.Model
-	Name     sql.NullString
+	Name      sql.NullString
-	Gender   *sql.NullString
+	Gender    *sql.NullString
-	Age      sql.NullInt64
+	Age       sql.NullInt64
-	Male     sql.NullBool
+	Male      sql.NullBool
-	Height   sql.NullFloat64
+	Height    sql.NullFloat64
-	Birthday sql.NullTime
+	Birthday  sql.NullTime
-	Password EncryptedData
+	Password  EncryptedData
-	Bytes    []byte
+	Bytes     []byte
-	Num      Num
+	Num       Num
-	Strings  StringsSlice
+	Strings   StringsSlice
-	Structs  StructsSlice
+	Structs   StructsSlice
-	Role     Role
+	Role      Role
-	UserID   *sql.NullInt64
+	UserID    *sql.NullInt64
-	User     User
+	User      User
+	EmptyTime EmptyTime
 }
 
 type EncryptedData []byte
@@ -244,3 +245,18 @@ func (role Role) Value() (driver.Value, error) {
 func (role Role) IsAdmin() bool {
 	return role.Name == "admin"
 }
+
+type EmptyTime struct {
+	time.Time
+}
+
+func (t *EmptyTime) Scan(v interface{}) error {
+	nullTime := sql.NullTime{}
+	err := nullTime.Scan(v)
+	t.Time = nullTime.Time
+	return err
+}
+
+func (t EmptyTime) Value() (driver.Value, error) {
+	return t.Time, nil
+}