From 6a35b8fe6eba9277c8bf22e9d695d4b316f89d6c Mon Sep 17 00:00:00 2001 From: Jim Lambert Date: Sat, 15 Feb 2020 16:13:31 -0500 Subject: [PATCH] rewrite using OraDialect to describe last inserted id differences --- dialects/oci8/doc.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dialects/oci8/doc.go b/dialects/oci8/doc.go index ffd5649a..6512498e 100644 --- a/dialects/oci8/doc.go +++ b/dialects/oci8/doc.go @@ -26,9 +26,10 @@ This design decision has the following side affects: 2. Oracle handles last inserted id a bit differently, and requires a sql.Out -parameter to return the value. Since Oracle parameters are positional, you -need to know how many other bind variables there are before adding the returning -clause. (see createCallback() ) +parameter to return the value in the oci8 driver. Since Oracle parameters +are positional, you need to know how many other bind variables there are before +adding the returning clause. We've implemented the +OraDialect.CreateWithReturningInto(*Scope) to handle this. 3. Oracle doesn't let you specify "AS " when selecting a count from a dynamic table, so you just omit it. (see Scope.count() )