tablet/gorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up: check error on scan and force compile check that oci8 implements the Dialect interface

Browse Source
This commit is contained in:
Jim Lambert 2020-02-14 16:49:36 -05:00
parent 53225196f4
commit 73d9a67b12
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dialects/oci8/oci8.go
View File

@ -14,6 +14,8 @@ import (
const dialectName = "oci8" const dialectName = "oci8"
var _ gorm.Dialect = (*oci8)(nil)
type oci8 struct { type oci8 struct {
db gorm.SQLCommon db gorm.SQLCommon
gorm.DefaultForeignKeyNamer gorm.DefaultForeignKeyNamer
@ -47,7 +49,9 @@ func (oci8) Quote(key string) string {
func (s oci8) CurrentDatabase() string { func (s oci8) CurrentDatabase() string {
var name string var name string
s.db.QueryRow("SELECT ORA_DATABASE_NAME as \"Current Database\" FROM DUAL").Scan(&name) if err := s.db.QueryRow("SELECT ORA_DATABASE_NAME as \"Current Database\" FROM DUAL").Scan(&name); err != nil {
return "" // just return "", since the Dialect interface doesn't support returning an error for this func
}
return name return name
} }