From b907a3d90211c38917b09477f4df9a855ad15981 Mon Sep 17 00:00:00 2001 From: Paul Walker Date: Tue, 15 Aug 2017 14:11:46 -0700 Subject: [PATCH 1/2] makes DialectsMap public for easier registration of dialects using existing values refs #1572 --- dialect.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dialect.go b/dialect.go index e879588b..229c043e 100644 --- a/dialect.go +++ b/dialect.go @@ -48,10 +48,10 @@ type Dialect interface { CurrentDatabase() string } -var dialectsMap = map[string]Dialect{} +var DialectsMap = map[string]Dialect{} func newDialect(name string, db SQLCommon) Dialect { - if value, ok := dialectsMap[name]; ok { + if value, ok := DialectsMap[name]; ok { dialect := reflect.New(reflect.TypeOf(value).Elem()).Interface().(Dialect) dialect.SetDB(db) return dialect @@ -65,7 +65,7 @@ func newDialect(name string, db SQLCommon) Dialect { // RegisterDialect register new dialect func RegisterDialect(name string, dialect Dialect) { - dialectsMap[name] = dialect + DialectsMap[name] = dialect } // ParseFieldStructForDialect get field's sql data type From 5092ef2980c3f1881f3cdfadec712cbde51da71d Mon Sep 17 00:00:00 2001 From: Paul Walker Date: Tue, 15 Aug 2017 14:18:20 -0700 Subject: [PATCH 2/2] include comment for member made public --- dialect.go | 1 + 1 file changed, 1 insertion(+) diff --git a/dialect.go b/dialect.go index 229c043e..7c5fdfee 100644 --- a/dialect.go +++ b/dialect.go @@ -48,6 +48,7 @@ type Dialect interface { CurrentDatabase() string } +// DialectsMap map of registered dialects var DialectsMap = map[string]Dialect{} func newDialect(name string, db SQLCommon) Dialect {