tablet/gorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

default maxIdentifierLength is 64

Browse Source
This commit is contained in:
mohammad ali ashraf 2023-05-30 06:34:29 +05:00
parent 563d9b588a
commit b8d39da106
4 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gorm.go
View File

@ -146,7 +146,7 @@ func Open(dialector Dialector, opts ...Option) (db *DB, err error) {
} }
if config.NamingStrategy == nil { if config.NamingStrategy == nil {
config.NamingStrategy = schema.NamingStrategy{IdentifierMaxLength: 63} config.NamingStrategy = schema.NamingStrategy{IdentifierMaxLength: 64} // Default Identifier length is 64
} }
if config.Logger == nil { if config.Logger == nil {

2
schema/naming.go
View File

@ -91,7 +91,7 @@ func (ns NamingStrategy) formatName(prefix, table, name string) string {
}, "_"), ".", "_") }, "_"), ".", "_")
if ns.IdentifierMaxLength == 0 { if ns.IdentifierMaxLength == 0 {
ns.IdentifierMaxLength = 63 ns.IdentifierMaxLength = 64
} }
if utf8.RuneCountInString(formattedName) > ns.IdentifierMaxLength { if utf8.RuneCountInString(formattedName) > ns.IdentifierMaxLength {

9
schema/naming_test.go
View File

@ -198,6 +198,15 @@ func TestFormatNameWithStringLongerThan63Characters(t *testing.T) {
} }
} }
func TestFormatNameWithStringLongerThan64Characters(t *testing.T) {
ns := NamingStrategy{IdentifierMaxLength: 64}
formattedName := ns.formatName("prefix", "table", "thisIsAVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString")
if formattedName != "prefix_table_thisIsAVeryVeryVeryVeryVeryVeryVeryVeryVery180f2c67" {
t.Errorf("invalid formatted name generated, got %v", formattedName)
}
}
func TestReplaceEmptyTableName(t *testing.T) { func TestReplaceEmptyTableName(t *testing.T) {
ns := NamingStrategy{ ns := NamingStrategy{
SingularTable: true, SingularTable: true,

4
schema/relationship_test.go
View File

@ -768,13 +768,13 @@ func TestParseConstraintNameWithSchemaQualifiedLongTableName(t *testing.T) {
s, err := schema.Parse( s, err := schema.Parse(
&Book{}, &Book{},
&sync.Map{}, &sync.Map{},
schema.NamingStrategy{IdentifierMaxLength: 63}, schema.NamingStrategy{IdentifierMaxLength: 64},
) )
if err != nil { if err != nil {
t.Fatalf("Failed to parse schema") t.Fatalf("Failed to parse schema")
} }
expectedConstraintName := "fk_my_schema_a_very_very_very_very_very_very_very_very_4db13eec" expectedConstraintName := "fk_my_schema_a_very_very_very_very_very_very_very_very_l4db13eec"
constraint := s.Relationships.Relations["Author"].ParseConstraint() constraint := s.Relationships.Relations["Author"].ParseConstraint()
if constraint.Name != expectedConstraintName { if constraint.Name != expectedConstraintName {