tablet/gorm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1140 from zardak/fix-tests

Browse Source 
Fix failing sqlite3 tests due to db connection not being closed
This commit is contained in:
Jinzhu 2016-08-11 10:59:00 +08:00 committed by GitHub
commit dda88dd08c
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
main_test.go
View File

@ -32,14 +32,6 @@ func init() {
panic(fmt.Sprintf("No error should happen when connecting to test database, but got err=%+v", err)) panic(fmt.Sprintf("No error should happen when connecting to test database, but got err=%+v", err))
} }
// DB.SetLogger(Logger{log.New(os.Stdout, "\r\n", 0)})
// DB.SetLogger(log.New(os.Stdout, "\r\n", 0))
if os.Getenv("DEBUG") == "true" {
DB.LogMode(true)
}
DB.DB().SetMaxIdleConns(10)
runMigration() runMigration()
} }
@ -72,6 +64,15 @@ func OpenTestConnection() (db *gorm.DB, err error) {
fmt.Println("testing sqlite3...") fmt.Println("testing sqlite3...")
db, err = gorm.Open("sqlite3", filepath.Join(os.TempDir(), "gorm.db")) db, err = gorm.Open("sqlite3", filepath.Join(os.TempDir(), "gorm.db"))
} }
// db.SetLogger(Logger{log.New(os.Stdout, "\r\n", 0)})
// db.SetLogger(log.New(os.Stdout, "\r\n", 0))
if os.Getenv("DEBUG") == "true" {
db.LogMode(true)
}
db.DB().SetMaxIdleConns(10)
return return
} }

2
query_test.go
View File

@ -628,6 +628,8 @@ func TestSelectWithVariables(t *testing.T) {
t.Errorf("Should only contains one column") t.Errorf("Should only contains one column")
} }
} }
rows.Close()
} }
func TestSelectWithArrayInput(t *testing.T) { func TestSelectWithArrayInput(t *testing.T) {