From f9131e309d0464e409f6107556297469e7dbf8fb Mon Sep 17 00:00:00 2001
From: Qt <golang.chen@gmail.com>
Date: Sun, 10 Jan 2021 10:15:48 +0800
Subject: [PATCH] reduce DB's Use method complexity and make it easier to
 understand (#3930)

---
 gorm.go | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/gorm.go b/gorm.go
index 488e74e7..355a0e55 100644
--- a/gorm.go
+++ b/gorm.go
@@ -380,15 +380,14 @@ func (db *DB) SetupJoinTable(model interface{}, field string, joinTable interfac
 	return nil
 }
 
-func (db *DB) Use(plugin Plugin) (err error) {
+func (db *DB) Use(plugin Plugin) error {
 	name := plugin.Name()
-	if _, ok := db.Plugins[name]; !ok {
-		if err = plugin.Initialize(db); err == nil {
-			db.Plugins[name] = plugin
-		}
-	} else {
+	if _, ok := db.Plugins[name]; ok {
 		return ErrRegistered
 	}
-
-	return err
+	if err := plugin.Initialize(db); err != nil {
+		return err
+	}
+	db.Plugins[name] = plugin
+	return nil
 }