From 0879ff7bc6e6b31126953d8a45f8090ea817c6e8 Mon Sep 17 00:00:00 2001 From: Glenn Washburn Date: Wed, 12 Nov 2025 21:10:39 -0600 Subject: [PATCH] tests/erofs_test: Fix mkfs.erofs version test to not use process substitution bashism The shell used to run the tests is generally /bin/sh, which does not support process substitution. Fixes: b990df0bef9e (tests/util/grub-fs-tester: Fix EROFS label tests in grub-fs-tester) Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Reviewed-by: Sudhakar Kuppusamy --- tests/util/grub-fs-tester.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 9a13f87a3..f8181837e 100644 --- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs-tester.in @@ -599,11 +599,12 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do | x"minix3" | xreiserfs_old) NOFSLABEL=y;; x"erofs_"*) - MKFS_EROFS_VERSION=$(mkfs.erofs -V 2>/dev/null | tr ' ' '\n' | grep '^[0-9]') + MKFS_EROFS_VERSION=$(mkfs.erofs 2>/dev/null | head -n 1 | (read _ V; echo $V)) # check if the version is at least 1.6 - if [ $(sort -V <(echo "$MKFS_EROFS_VERSION") <(echo "1.6") | head -n 1) != "1.6" ]; then + if [ "$(echo -e "${MKFS_EROFS_VERSION}\n1.6" | sort -V | head -n 1)" != "1.6" ]; then NOFSLABEL=y - fi + unset FSLABEL + fi;; esac PDIRCOMPNUM=210