tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

util/grub-install-common: Confirm directory creation in grub_install_mkdir_p()

Browse Source 
Because grub_util_mkdir() is implemented to not return a value on any
platform, grub_instal_mkdir_p() can test for success by confirming that
the directory requested exists after attempting to create it, otherwise
it should fail with an error and exit.

While fixing this, a flaw in the logic was shown, where the first match
of the path separator, which almost always was the first character in
the path (e.g. /boot/grub2) would result in creating a directory with an
empty name (i.e. ""). To avoid that, it should skip the handling of the
path separator where p is pointing to the first character.

Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Darren Kenny 2022-08-09 13:29:05 +00:00 committed by Daniel Kiper
parent d22cbe0dec
commit 2669f98643
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
util/grub-install-common.c
View File

@ -173,15 +173,20 @@ grub_install_mkdir_p (const char *dst)
char *p;
for (p = t; *p; p++)
{
if (is_path_separator (*p))
if (is_path_separator (*p) && p != t)
{
char s = *p;
*p = '\0';
grub_util_mkdir (t);
if (!grub_util_is_directory (t))
grub_util_error (_("failed to make directory: '%s'"), t);
*p = s;
}
}
grub_util_mkdir (t);
if (!grub_util_is_directory (t))
grub_util_error (_("failed to make directory: '%s'"), t);
free (t);
}