From 4cc22937e780f22d7b469d2da8df701957913de7 Mon Sep 17 00:00:00 2001 From: Avnish Chouhan Date: Tue, 28 Oct 2025 22:02:00 +0530 Subject: [PATCH] partmap/msdos: Add missing grub_malloc() failure check This patch adds a NULL check after grub_malloc() call. Missing a failure check after calling grub_malloc() can lead to undefined behavior. If the allocation fails and returns NULL subsequent dereferencing or writing to the pointer will likely result in a runtime error such as a segmentation fault. Signed-off-by: Avnish Chouhan Reviewed-by: Sudhakar Kuppusamy Reviewed-by: Daniel Kiper --- grub-core/partmap/msdos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/partmap/msdos.c b/grub-core/partmap/msdos.c index c85bb74be..bf926175e 100644 --- a/grub-core/partmap/msdos.c +++ b/grub-core/partmap/msdos.c @@ -348,6 +348,9 @@ pc_partition_map_embed (struct grub_disk *disk, unsigned int *nsectors, * area. */ embed_signature_check = grub_malloc (GRUB_DISK_SECTOR_SIZE); + if (embed_signature_check == NULL) + return grub_errno; + for (i = 0; i < *nsectors; i++) { if (grub_disk_read (disk, (*sectors)[i], 0, GRUB_DISK_SECTOR_SIZE,