tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

util/grub-fstest: Fix resource leaks in cmd_cmp()

Browse Source 
In the function cmd_cmp() within the while loop, srcnew and destnew are
being allocated but are never freed either before leaving scope or in
the recursive calls being made to cmd_cmp().

Fixes: CID 314032
Fixes: CID 314045

Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Darren Kenny 2021-10-26 15:02:37 +00:00 committed by Daniel Kiper
parent eff17a6b2d
commit 53f08de12b
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
util/grub-fstest.c
View File

@ -300,9 +300,15 @@ cmd_cmp (char *src, char *dest)
strcpy (ptr, entry->d_name);
if (grub_util_is_special_file (destnew))
continue;
{
free (srcnew);
free (destnew);
continue;
}
cmd_cmp (srcnew, destnew);
free (srcnew);
free (destnew);
}
grub_util_fd_closedir (dir);
return;