tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

term/ieee1275/serial: Fix memory leak

Browse Source 
The grub_zalloc() allocates memory for port. If the allocation for
port->name fails the function returns NULL without freeing the
previously allocated port memory. This results in a memory leak.
To avoid this we must free port before return.

Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Avnish Chouhan 2025-10-28 21:58:51 +05:30 committed by Daniel Kiper
parent cc36d0f088
commit 5f0ffd7f57
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
grub-core/term/ieee1275/serial.c
View File

@ -236,7 +236,11 @@ add_port (struct ofserial_hash_ent *ent)
+ grub_strlen (ent->shortest)); + grub_strlen (ent->shortest));
port->elem = ent; port->elem = ent;
if (!port->name) if (!port->name)
return NULL; {
grub_free (port);
return NULL;
}
ptr = grub_stpcpy (port->name, "ieee1275/"); ptr = grub_stpcpy (port->name, "ieee1275/");
grub_strcpy (ptr, ent->shortest); grub_strcpy (ptr, ent->shortest);