tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

term/at_keyboard: Add timeout to fix hang on HP EliteBooks

Browse Source 
This fixes the GRUB on Coreboot on HP EliteBooks by implementing
a 200 ms timeout. The GRUB used to hang.

Fixes: https://ticket.coreboot.org/issues/141

Signed-off-by: Riku Viitanen <riku.viitanen@protonmail.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Riku Viitanen 2023-04-23 09:59:34 +00:00 committed by Daniel Kiper
parent e67a551a48
commit 830456a6e3
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
grub-core/term/at_keyboard.c
View File

@ -40,9 +40,19 @@ grub_keyboard_controller_init (void);
static void static void
keyboard_controller_wait_until_ready (void) keyboard_controller_wait_until_ready (void)
{ {
unsigned int i = 200;
/* 50 us would be enough but our current time resolution is 1ms. */ /* 50 us would be enough but our current time resolution is 1ms. */
grub_millisleep (1); grub_millisleep (1);
while (! KEYBOARD_COMMAND_ISREADY (grub_inb (KEYBOARD_REG_STATUS)));
while (!KEYBOARD_COMMAND_ISREADY (grub_inb (KEYBOARD_REG_STATUS)))
{
grub_millisleep (1);
/* Timeout. */
if (!i--)
break;
}
} }
static grub_uint8_t static grub_uint8_t