tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

Browse Source 
Latest GCC may complain in that way:

  commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’:
  commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
    223 |   *((char *) 0x41a) = 0x1e;
        |   ~~~~~~~~~~~~~~~~~~^~~~~~

The volatile keyword addition helps and additionally assures us the
compiler will not optimize out fixed assignments.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
This commit is contained in:
Daniel Kiper 2022-03-10 16:48:50 +01:00
parent 093ac51dc6
commit 9c9bb1c0ac
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
grub-core/commands/i386/pc/sendkey.c
View File

@ -220,8 +220,8 @@ grub_sendkey_postboot (void)
*flags = oldflags;
*((char *) 0x41a) = 0x1e;
*((char *) 0x41c) = 0x1e;
*((volatile char *) 0x41a) = 0x1e;
*((volatile char *) 0x41c) = 0x1e;
return GRUB_ERR_NONE;
}
@ -236,8 +236,8 @@ grub_sendkey_preboot (int noret __attribute__ ((unused)))
oldflags = *flags;
/* Set the sendkey. */
*((char *) 0x41a) = 0x1e;
*((char *) 0x41c) = keylen + 0x1e;
*((volatile char *) 0x41a) = 0x1e;
*((volatile char *) 0x41c) = keylen + 0x1e;
grub_memcpy ((char *) 0x41e, sendkey, 0x20);
/* Transform "any ctrl" to "right ctrl" flag. */