tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

commands/tpm: Don't propagate measurement failures to the verifiers layer

Browse Source 
Currently if an EFI firmware fails to do a TPM measurement for a file,
the error will be propagated to the verifiers framework which will
prevent it to be opened. This mean that buggy firmwares will lead to
the system not booting because files won't be allowed to be loaded. But
a failure to do a TPM measurement isn't expected to be a fatal error
that causes the system to be unbootable.

To avoid this, don't return errors from .write and .verify_string
callbacks and just print a debug message in the case of a TPM
measurement failure. Add an environment variable, tpm_fail_fatal, to
restore the previous behavior.

Also-authored-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Robbie Harwood 2022-11-04 12:13:36 -04:00 committed by Daniel Kiper
parent b20192f22c
commit a4356538d0
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/grub.texi
View File

@ -3342,6 +3342,7 @@ These variables have special meaning to GRUB.
* theme::
* timeout::
* timeout_style::
* tpm_fail_fatal::
@end menu
@ -3849,6 +3850,15 @@ displaying the menu. See the documentation of @samp{GRUB_TIMEOUT_STYLE}
(@pxref{Simple configuration}) for details.
@node tpm_fail_fatal
@subsection tpm_fail_fatal
If this variable is set and true (i.e., not set to ``0'', ``false'',
``disable'', or ``no''), TPM measurements that fail will be treated as
fatal. Otherwise, they will merely be debug-logged and boot will
continue.
@node Environment block
@section The GRUB environment block

21
grub-core/commands/tpm.c
View File

@ -18,6 +18,7 @@
* Core TPM support code.
*/
#include <grub/env.h>
#include <grub/err.h>
#include <grub/i18n.h>
#include <grub/misc.h>
@ -39,10 +40,22 @@ grub_tpm_verify_init (grub_file_t io,
return GRUB_ERR_NONE;
}
static inline bool
is_tpm_fail_fatal (void)
{
return grub_env_get_bool ("tpm_fail_fatal", false);
}
static grub_err_t
grub_tpm_verify_write (void *context, void *buf, grub_size_t size)
{
return grub_tpm_measure (buf, size, GRUB_BINARY_PCR, context);
grub_err_t status = grub_tpm_measure (buf, size, GRUB_BINARY_PCR, context);
if (status == GRUB_ERR_NONE)
return GRUB_ERR_NONE;
grub_dprintf ("tpm", "Measuring buffer failed: %d\n", status);
return is_tpm_fail_fatal () ? status : GRUB_ERR_NONE;
}
static grub_err_t
@ -74,7 +87,11 @@ grub_tpm_verify_string (char *str, enum grub_verify_string_type type)
grub_tpm_measure ((unsigned char *) str, grub_strlen (str),
GRUB_STRING_PCR, description);
grub_free (description);
return status;
if (status == GRUB_ERR_NONE)
return GRUB_ERR_NONE;
grub_dprintf ("tpm", "Measuring string %s failed: %d\n", str, status);
return is_tpm_fail_fatal () ? status : GRUB_ERR_NONE;
}
struct grub_file_verifier grub_tpm_verifier = {