tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

acpi: Mark MADT entries as packed

Browse Source 
No alignment is guaranteed and in fact on my IA-64 SAPIC is aligned
to 4 bytes instead of 8 and causes a trap. It affects only rarely used
lsacpi command and so went unnoticed.

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Vladimir 'phcoder' Serbinenko 2024-03-15 22:02:07 +03:00 committed by Daniel Kiper
parent 39c927df66
commit aa80270154
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/grub/acpi.h
View File

@ -81,6 +81,7 @@ struct grub_acpi_fadt
#define GRUB_ACPI_MADT_SIGNATURE "APIC"
/* Note: here GRUB_PACKED is not needed because we have grub_uint8_t only. */
struct grub_acpi_madt_entry_header
{
grub_uint8_t type;
@ -112,7 +113,7 @@ struct grub_acpi_madt_entry_lapic
grub_uint8_t acpiid;
grub_uint8_t apicid;
grub_uint32_t flags;
};
} GRUB_PACKED;
struct grub_acpi_madt_entry_ioapic
{
@ -121,7 +122,7 @@ struct grub_acpi_madt_entry_ioapic
grub_uint8_t pad;
grub_uint32_t address;
grub_uint32_t global_sys_interrupt;
};
} GRUB_PACKED;
struct grub_acpi_madt_entry_interrupt_override
{
@ -148,7 +149,7 @@ struct grub_acpi_madt_entry_sapic
grub_uint8_t pad;
grub_uint32_t global_sys_interrupt_base;
grub_uint64_t addr;
};
} GRUB_PACKED;
struct grub_acpi_madt_entry_lsapic
{
@ -160,7 +161,7 @@ struct grub_acpi_madt_entry_lsapic
grub_uint32_t flags;
grub_uint32_t cpu_uid;
grub_uint8_t cpu_uid_str[0];
};
} GRUB_PACKED;
struct grub_acpi_madt_entry_platform_int_source
{
@ -172,7 +173,7 @@ struct grub_acpi_madt_entry_platform_int_source
grub_uint8_t sapic_vector;
grub_uint32_t global_sys_int;
grub_uint32_t src_flags;
};
} GRUB_PACKED;
enum
{