tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

normal/completion: Add missing grub_malloc() failure check

Browse Source 
This patch adds a NULL check after grub_malloc() call. Missing a failure
check after calling grub_malloc() can lead to undefined behavior. If the
allocation fails and returns NULL subsequent dereferencing or writing to
the pointer will likely result in a runtime error such as a segmentation
fault.

Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Avnish Chouhan 2025-10-28 22:01:59 +05:30 committed by Daniel Kiper
parent 5f0ffd7f57
commit c0d2f76d55
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
grub-core/normal/completion.c
View File

@ -490,6 +490,9 @@ grub_normal_do_completion (char *buf, int *restore,
spaces++; spaces++;
ret = grub_malloc (match_len - current_len + grub_strlen (suffix) + spaces + 1); ret = grub_malloc (match_len - current_len + grub_strlen (suffix) + spaces + 1);
if (ret == NULL)
goto fail;
newstr = ret; newstr = ret;
for (escstr = match + current_len; *escstr; escstr++) for (escstr = match + current_len; *escstr; escstr++)
{ {