tablet/grub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

util/bash-completion: Fix SC2155 shellcheck warning

Browse Source 
SC2155 (warning): Declare and assign separately to avoid masking return values.

The exit status of the command is overridden by the exit status of the
creation of the local variable.

In grub-completion.bash.in line 115:
    local config_file=$(__grub_dir)/grub.cfg
          ^---------^ SC2155 (warning)

In grub-completion.bash.in line 126:
    local grub_dir=$(__grub_dir)
          ^------^ SC2155 (warning)

More: https://github.com/koalaman/shellcheck/wiki/SC2155

Signed-off-by: t.feng <fengtao40@huawei.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
t.feng 2022-12-06 21:49:30 +08:00 committed by Daniel Kiper
parent 61e4f408b0
commit e9802fbdeb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/bash-completion.d/grub-completion.bash.in
View File

@ -115,7 +115,8 @@ __grub_get_last_option () {
__grub_list_menuentries () {
local cur="${COMP_WORDS[COMP_CWORD]}"
local config_file=$(__grub_dir)/grub.cfg
local config_file
config_file=$(__grub_dir)/grub.cfg
if [ -f "$config_file" ];then
local line IFS=$'\n'
@ -129,7 +130,8 @@ __grub_list_menuentries () {
}
__grub_list_modules () {
local grub_dir=$(__grub_dir)
local grub_dir
grub_dir=$(__grub_dir)
local line tmp IFS=$'\n'
COMPREPLY=()
while read -r line; do