The GRUB is failing to build with GCC-12 in many places like this:
In function 'init_cbfsdisk',
inlined from 'grub_mod_init' at ../../grub-core/fs/cbfs.c:391:3:
../../grub-core/fs/cbfs.c:345:7: error: array subscript 0 is outside array bounds of 'grub_uint32_t[0]' {aka 'unsigned int[]'} [-Werror=array-bounds]
345 | ptr = *(grub_uint32_t *) 0xfffffffc;
| ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is caused by GCC regression in 11/12 [1]. In a nut shell, the
warning is about detected invalid accesses at non-zero offsets to NULL
pointers. Since hardwired constant address is treated as NULL plus an
offset in the same underlying code, the warning is therefore triggered.
Instead of inserting #pragma all over the places where literal pointers
are accessed to avoid diagnosing array-bounds, we can try to borrow the
idea from Linux kernel that the absolute_pointer() macro [2][3] is used
to disconnect a pointer using literal address from it's original object,
hence GCC won't be able to make assumptions on the boundary while doing
pointer arithmetic. With that we can greatly reduce the code we have to
cover up by making initial literal pointer assignment to use the new
wrapper but not having to track everywhere literal pointers are
accessed. This also makes code looks cleaner.
Please note the grub_absolute_pointer() macro requires to be invoked in
a function as long as it is compound expression. Some global variables
with literal pointers has been changed to local ones in order to use
grub_absolute_pointer() to initialize it. The shuffling is basically done
in a selective and careful way that the variable's scope doesn't matter
being local or global, for example, the global variable must not get
modified at run time throughout. For the record, here's the list of
global variables got shuffled in this patch:
grub-core/commands/i386/pc/drivemap.c:int13slot
grub-core/term/i386/pc/console.c:bios_data_area
grub-core/term/ns8250.c:serial_hw_io_addr
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578
[2] https://elixir.bootlin.com/linux/v5.16.14/source/include/linux/compiler.h#L180
[3] https://elixir.bootlin.com/linux/v5.16.14/source/include/linux/compiler-gcc.h#L31
Signed-off-by: Michael Chang <mchang@suse.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
224 lines
5.8 KiB
C
224 lines
5.8 KiB
C
/* loadbios.c - command to load a bios dump */
|
|
/*
|
|
* GRUB -- GRand Unified Bootloader
|
|
* Copyright (C) 2009 Free Software Foundation, Inc.
|
|
*
|
|
* GRUB is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* GRUB is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with GRUB. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <grub/dl.h>
|
|
#include <grub/misc.h>
|
|
#include <grub/file.h>
|
|
#include <grub/efi/efi.h>
|
|
#include <grub/pci.h>
|
|
#include <grub/command.h>
|
|
#include <grub/i18n.h>
|
|
|
|
GRUB_MOD_LICENSE ("GPLv3+");
|
|
|
|
static grub_efi_guid_t acpi_guid = GRUB_EFI_ACPI_TABLE_GUID;
|
|
static grub_efi_guid_t acpi2_guid = GRUB_EFI_ACPI_20_TABLE_GUID;
|
|
static grub_efi_guid_t smbios_guid = GRUB_EFI_SMBIOS_TABLE_GUID;
|
|
|
|
#define EBDA_SEG_ADDR 0x40e
|
|
#define LOW_MEM_ADDR 0x413
|
|
#define FAKE_EBDA_SEG 0x9fc0
|
|
|
|
#define BLANK_MEM 0xffffffff
|
|
#define VBIOS_ADDR 0xc0000
|
|
#define SBIOS_ADDR 0xf0000
|
|
|
|
static int
|
|
enable_rom_area (void)
|
|
{
|
|
grub_pci_address_t addr;
|
|
grub_uint32_t *rom_ptr;
|
|
grub_pci_device_t dev = { .bus = 0, .device = 0, .function = 0};
|
|
|
|
rom_ptr = grub_absolute_pointer (VBIOS_ADDR);
|
|
if (*rom_ptr != BLANK_MEM)
|
|
{
|
|
grub_puts_ (N_("ROM image is present."));
|
|
return 0;
|
|
}
|
|
|
|
/* FIXME: should be macroified. */
|
|
addr = grub_pci_make_address (dev, 144);
|
|
grub_pci_write_byte (addr++, 0x30);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr++, 0x33);
|
|
grub_pci_write_byte (addr, 0);
|
|
|
|
*rom_ptr = 0;
|
|
if (*rom_ptr != 0)
|
|
{
|
|
grub_puts_ (N_("Can\'t enable ROM area."));
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static void
|
|
lock_rom_area (void)
|
|
{
|
|
grub_pci_address_t addr;
|
|
grub_pci_device_t dev = { .bus = 0, .device = 0, .function = 0};
|
|
|
|
/* FIXME: should be macroified. */
|
|
addr = grub_pci_make_address (dev, 144);
|
|
grub_pci_write_byte (addr++, 0x10);
|
|
grub_pci_write_byte (addr++, 0x11);
|
|
grub_pci_write_byte (addr++, 0x11);
|
|
grub_pci_write_byte (addr++, 0x11);
|
|
grub_pci_write_byte (addr, 0x11);
|
|
}
|
|
|
|
static void
|
|
fake_bios_data (int use_rom)
|
|
{
|
|
unsigned i;
|
|
void *acpi, *smbios;
|
|
grub_uint16_t *ebda_seg_ptr, *low_mem_ptr;
|
|
|
|
ebda_seg_ptr = grub_absolute_pointer (EBDA_SEG_ADDR);
|
|
low_mem_ptr = grub_absolute_pointer (LOW_MEM_ADDR);
|
|
if ((*ebda_seg_ptr) || (*low_mem_ptr))
|
|
return;
|
|
|
|
acpi = 0;
|
|
smbios = 0;
|
|
for (i = 0; i < grub_efi_system_table->num_table_entries; i++)
|
|
{
|
|
grub_efi_packed_guid_t *guid =
|
|
&grub_efi_system_table->configuration_table[i].vendor_guid;
|
|
|
|
if (! grub_memcmp (guid, &acpi2_guid, sizeof (grub_efi_guid_t)))
|
|
{
|
|
acpi = grub_efi_system_table->configuration_table[i].vendor_table;
|
|
grub_dprintf ("efi", "ACPI2: %p\n", acpi);
|
|
}
|
|
else if (! grub_memcmp (guid, &acpi_guid, sizeof (grub_efi_guid_t)))
|
|
{
|
|
void *t;
|
|
|
|
t = grub_efi_system_table->configuration_table[i].vendor_table;
|
|
if (! acpi)
|
|
acpi = t;
|
|
grub_dprintf ("efi", "ACPI: %p\n", t);
|
|
}
|
|
else if (! grub_memcmp (guid, &smbios_guid, sizeof (grub_efi_guid_t)))
|
|
{
|
|
smbios = grub_efi_system_table->configuration_table[i].vendor_table;
|
|
grub_dprintf ("efi", "SMBIOS: %p\n", smbios);
|
|
}
|
|
}
|
|
|
|
*ebda_seg_ptr = FAKE_EBDA_SEG;
|
|
*low_mem_ptr = (FAKE_EBDA_SEG >> 6);
|
|
|
|
/* *((grub_uint16_t *) (FAKE_EBDA_SEG << 4)) = 640 - *low_mem_ptr; */
|
|
*((grub_uint16_t *) (grub_absolute_pointer (FAKE_EBDA_SEG << 4))) = 640 - *low_mem_ptr;
|
|
|
|
if (acpi)
|
|
grub_memcpy ((char *) ((FAKE_EBDA_SEG << 4) + 16), acpi, 1024 - 16);
|
|
|
|
if ((use_rom) && (smbios))
|
|
grub_memcpy ((char *) SBIOS_ADDR, (char *) smbios + 16, 16);
|
|
}
|
|
|
|
static grub_err_t
|
|
grub_cmd_fakebios (struct grub_command *cmd __attribute__ ((unused)),
|
|
int argc __attribute__ ((unused)),
|
|
char *argv[] __attribute__ ((unused)))
|
|
{
|
|
if (enable_rom_area ())
|
|
{
|
|
fake_bios_data (1);
|
|
lock_rom_area ();
|
|
}
|
|
else
|
|
fake_bios_data (0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static grub_err_t
|
|
grub_cmd_loadbios (grub_command_t cmd __attribute__ ((unused)),
|
|
int argc, char *argv[])
|
|
{
|
|
grub_file_t file;
|
|
int size;
|
|
|
|
if (argc == 0)
|
|
return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
|
|
|
|
if (argc > 1)
|
|
{
|
|
file = grub_file_open (argv[1], GRUB_FILE_TYPE_VBE_DUMP);
|
|
if (! file)
|
|
return grub_errno;
|
|
|
|
if (file->size != 4)
|
|
grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid int10 dump size");
|
|
else
|
|
grub_file_read (file, (void *) 0x40, 4);
|
|
|
|
grub_file_close (file);
|
|
if (grub_errno)
|
|
return grub_errno;
|
|
}
|
|
|
|
file = grub_file_open (argv[0], GRUB_FILE_TYPE_VBE_DUMP);
|
|
if (! file)
|
|
return grub_errno;
|
|
|
|
size = file->size;
|
|
if ((size < 0x10000) || (size > 0x40000))
|
|
grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid bios dump size");
|
|
else if (enable_rom_area ())
|
|
{
|
|
grub_file_read (file, (void *) VBIOS_ADDR, size);
|
|
fake_bios_data (size <= 0x40000);
|
|
lock_rom_area ();
|
|
}
|
|
|
|
grub_file_close (file);
|
|
return grub_errno;
|
|
}
|
|
|
|
static grub_command_t cmd_fakebios, cmd_loadbios;
|
|
|
|
GRUB_MOD_INIT(loadbios)
|
|
{
|
|
cmd_fakebios = grub_register_command_lockdown ("fakebios", grub_cmd_fakebios,
|
|
0, N_("Create BIOS-like structures for"
|
|
" backward compatibility with"
|
|
" existing OS."));
|
|
|
|
cmd_loadbios = grub_register_command_lockdown ("loadbios", grub_cmd_loadbios,
|
|
N_("BIOS_DUMP [INT10_DUMP]"),
|
|
N_("Load BIOS dump."));
|
|
}
|
|
|
|
GRUB_MOD_FINI(loadbios)
|
|
{
|
|
grub_unregister_command (cmd_fakebios);
|
|
grub_unregister_command (cmd_loadbios);
|
|
}
|