the-btfash-foundation/Markwon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary use of density for scaling

Browse Source 
Additionally, improve naming.
This commit is contained in:
michel.onwordi 2018-01-09 15:20:43 +01:00
parent a77c84a30c
commit 40f42c5b8e
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
library/src/main/java/ru/noties/markwon/spans/SpannableTheme.java
View File

@ -114,7 +114,7 @@ public class SpannableTheme {
// taken from html spec (most browsers render headings like that) // taken from html spec (most browsers render headings like that)
// is not exposed via protected modifier in order to disallow modification // is not exposed via protected modifier in order to disallow modification
private static final float[] HEADING_SIZES = { private static final float[] HEADING_SCALES = {
2.F, 1.5F, 1.17F, 1.F, .83F, .67F, 2.F, 1.5F, 1.17F, 1.F, .83F, .67F,
}; };
@ -348,7 +348,7 @@ public class SpannableTheme {
paint.setFakeBoldText(true); paint.setFakeBoldText(true);
final float textSize = headingTypeConfig.getTextSize() > 0 ? final float textSize = headingTypeConfig.getTextSize() > 0 ?
headingTypeConfig.getTextSize() : HEADING_SIZES[level - 1]; headingTypeConfig.getTextSize() : HEADING_SCALES[level - 1];
paint.setTextSize(paint.getTextSize() * textSize); paint.setTextSize(paint.getTextSize() * textSize);
final int textColor = headingTypeConfig.getTextColor(); final int textColor = headingTypeConfig.getTextColor();

5
library/src/main/java/ru/noties/markwon/spans/configuration/heading/HeadingConfig.kt
View File

@ -49,16 +49,13 @@ class HeadingConfig @JvmOverloads constructor(
*/ */
class HeadingTypeConfig @JvmOverloads constructor( class HeadingTypeConfig @JvmOverloads constructor(
//Standard sizes available at #SpannableTheme.java:HEADING_SIZES //Standard sizes available at #SpannableTheme.java:HEADING_SIZES
textSize: Float = -1F, val textSize: Float = -1F,
@ColorInt val textColor: Int = -1, @ColorInt val textColor: Int = -1,
val typeface: Typeface? = null val typeface: Typeface? = null
) { ) {
internal var densityFactor: Float = -1F internal var densityFactor: Float = -1F
val textSize: Float = textSize
get() = field * densityFactor
} }
/** /**