diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a8dfef7..c726906c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ # SNAPSHOT +#### Changed +* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) + #### Fixed * `image-coil` - deliver image result if it loaded before request disposable is created ([#272]) * `ext-tables` - fix column width rounding issue diff --git a/app-sample/build.gradle b/app-sample/build.gradle index 623c8bf2..9e827415 100644 --- a/app-sample/build.gradle +++ b/app-sample/build.gradle @@ -159,6 +159,7 @@ dependencies { implementation it['debug'] implementation it['android-svg'] implementation it['android-gif-impl'] + implementation it['coil'] } deps['test'].with { diff --git a/build.gradle b/build.gradle index 16b72580..5fb64e81 100644 --- a/build.gradle +++ b/build.gradle @@ -58,6 +58,7 @@ ext { final def commonMarkVersion = '0.13.0' final def daggerVersion = '2.10' + final def coilVersion = '0.10.1' // please note that `pl.droidsonroids.gif:android-gif-drawable:1.2.15` is used due to the minimum // api level mismatch that Markwon supports (16) and later versions of AndroidGifDrawable (17). @@ -86,7 +87,8 @@ ext { 'dagger' : "com.google.dagger:dagger:$daggerVersion", 'picasso' : 'com.squareup.picasso:picasso:2.71828', 'glide' : 'com.github.bumptech.glide:glide:4.9.0', - 'coil' : 'io.coil-kt:coil:0.10.1', + 'coil' : "io.coil-kt:coil:$coilVersion", + 'coil-base' : "io.coil-kt:coil-base:$coilVersion", 'ix-java' : 'com.github.akarnokd:ixjava:1.0.0', 'gson' : 'com.google.code.gson:gson:2.8.6', 'commons-io' : 'commons-io:commons-io:2.6' diff --git a/docs/docs/v4/image-coil/README.md b/docs/docs/v4/image-coil/README.md index 5227ed7b..3e9a918b 100644 --- a/docs/docs/v4/image-coil/README.md +++ b/docs/docs/v4/image-coil/README.md @@ -2,7 +2,7 @@ -Image loading based on `Coil` library +Image loading based on `Coil` library. ```kotlin val markwon = Markwon.builder(context) @@ -33,3 +33,8 @@ val markwon = Markwon.builder(context) }, customImageLoader)) .build() ``` + +:::warning +In order to use the `CoilImagesPlugin.create(Context)` factory method your +app must have **explicit** dependency on `coil` library +::: \ No newline at end of file diff --git a/markwon-image-coil/build.gradle b/markwon-image-coil/build.gradle index aa760dfb..42d36848 100644 --- a/markwon-image-coil/build.gradle +++ b/markwon-image-coil/build.gradle @@ -15,7 +15,11 @@ android { dependencies { api project(':markwon-core') - api deps['coil'] + + // @since $SNAPSHOT; declare `coil-base` as api dependency (would require users + // to have explicit coil dependency) + api deps['coil-base'] + compileOnly deps['coil'] } registerArtifact(this)