JLatexMathPlugin error handler non-null latex argument

This commit is contained in:
Dimitry Ivanov 2020-03-02 10:46:18 +03:00
parent a1f12641c3
commit 5c3763a9a1

View File

@ -69,14 +69,13 @@ public class JLatexMathPlugin extends AbstractMarkwonPlugin {
public interface ErrorHandler { public interface ErrorHandler {
/** /**
* @param latex that caused the error or null if operated `AsyncDrawable` * @param latex that caused the error
* is not an instance of `JLatexAsyncDrawable`
* @param error occurred * @param error occurred
* @return (optional) error drawable that will be used instead (if drawable will have bounds * @return (optional) error drawable that will be used instead (if drawable will have bounds
* it will be used, if not intrinsic bounds will be set) * it will be used, if not intrinsic bounds will be set)
*/ */
@Nullable @Nullable
Drawable handleError(@Nullable String latex, @NonNull Throwable error); Drawable handleError(@NonNull String latex, @NonNull Throwable error);
} }
public interface BuilderConfigure { public interface BuilderConfigure {
@ -323,12 +322,14 @@ public class JLatexMathPlugin extends AbstractMarkwonPlugin {
/** /**
* @since 4.3.0-SNAPSHOT * @since 4.3.0-SNAPSHOT
*/ */
@SuppressWarnings("UnusedReturnValue")
@NonNull @NonNull
public Builder renderMode(@NonNull RenderMode renderMode) { public Builder renderMode(@NonNull RenderMode renderMode) {
this.renderMode = renderMode; this.renderMode = renderMode;
return this; return this;
} }
@SuppressWarnings("UnusedReturnValue")
@NonNull @NonNull
public Builder errorHandler(@Nullable ErrorHandler errorHandler) { public Builder errorHandler(@Nullable ErrorHandler errorHandler) {
this.errorHandler = errorHandler; this.errorHandler = errorHandler;
@ -338,6 +339,7 @@ public class JLatexMathPlugin extends AbstractMarkwonPlugin {
/** /**
* @since 4.0.0 * @since 4.0.0
*/ */
@SuppressWarnings({"UnusedReturnValue", "WeakerAccess"})
@NonNull @NonNull
public Builder executorService(@NonNull ExecutorService executorService) { public Builder executorService(@NonNull ExecutorService executorService) {
this.executorService = executorService; this.executorService = executorService;
@ -390,6 +392,7 @@ public class JLatexMathPlugin extends AbstractMarkwonPlugin {
"Error displaying latex: `" + drawable.getDestination() + "`", "Error displaying latex: `" + drawable.getDestination() + "`",
t); t);
} else { } else {
// just call `getDestination` without casts and checks
final Drawable errorDrawable = errorHandler.handleError( final Drawable errorDrawable = errorHandler.handleError(
drawable.getDestination(), drawable.getDestination(),
t t