From 602891566d50c1f49401459952b3b3f534faa7b0 Mon Sep 17 00:00:00 2001 From: Dimitry Ivanov Date: Thu, 13 Aug 2020 18:59:30 +0300 Subject: [PATCH] Prepare 4.5.1 release --- CHANGELOG.md | 8 +++++--- markwon-image-coil/build.gradle | 2 +- .../io/noties/markwon/image/coil/CoilImagesPlugin.java | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c726906c..fda1dbf3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,15 +1,17 @@ # Changelog -# SNAPSHOT +# 4.5.1 #### Changed -* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) +* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) ([#274]) #### Fixed * `image-coil` - deliver image result if it loaded before request disposable is created ([#272]) * `ext-tables` - fix column width rounding issue -[#272]: https://github.com/noties/Markwon/issues/272 +[#272]: https://github.com/noties/Markwon/issues/272 +[#274]: https://github.com/noties/Markwon/issues/274 + # 4.5.0 diff --git a/markwon-image-coil/build.gradle b/markwon-image-coil/build.gradle index 42d36848..26fe01ea 100644 --- a/markwon-image-coil/build.gradle +++ b/markwon-image-coil/build.gradle @@ -16,7 +16,7 @@ android { dependencies { api project(':markwon-core') - // @since $SNAPSHOT; declare `coil-base` as api dependency (would require users + // @since 4.5.1 declare `coil-base` as api dependency (would require users // to have explicit coil dependency) api deps['coil-base'] compileOnly deps['coil'] diff --git a/markwon-image-coil/src/main/java/io/noties/markwon/image/coil/CoilImagesPlugin.java b/markwon-image-coil/src/main/java/io/noties/markwon/image/coil/CoilImagesPlugin.java index 464edf1f..0019de21 100644 --- a/markwon-image-coil/src/main/java/io/noties/markwon/image/coil/CoilImagesPlugin.java +++ b/markwon-image-coil/src/main/java/io/noties/markwon/image/coil/CoilImagesPlugin.java @@ -130,7 +130,7 @@ public class CoilImagesPlugin extends AbstractMarkwonPlugin { final LoadRequest request = coilStore.load(drawable).newBuilder() .target(target) .build(); - // @since $SNAPSHOT; execute can return result _before_ disposable is created, + // @since 4.5.1 execute can return result _before_ disposable is created, // thus `execute` would finish before we put disposable in cache (and thus result is // not delivered) final RequestDisposable disposable = imageLoader.execute(request); @@ -168,7 +168,7 @@ public class CoilImagesPlugin extends AbstractMarkwonPlugin { @Override public void onSuccess(@NonNull Drawable loadedDrawable) { - // @since $SNAPSHOT; check finished flag (result can be delivered _before_ disposable is created) + // @since 4.5.1 check finished flag (result can be delivered _before_ disposable is created) if (cache.remove(drawable) != null || !loaded.get()) { // mark