the-btfash-foundation/Markwon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #275 from ubuntudroid/bugfix/reproduce-image-loading-on-second-view

Browse Source 
Use singleton coil instance in recycler view sample to reproduce image loading issue on second view
This commit is contained in:
Dimitry 2020-08-10 11:06:43 +03:00 committed by GitHub
commit 961ff32c9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app-sample/src/main/java/io/noties/markwon/app/samples/image/CoilRecyclerViewSample.kt
View File

@ -1,6 +1,7 @@
package io.noties.markwon.app.samples.image package io.noties.markwon.app.samples.image
import androidx.recyclerview.widget.LinearLayoutManager import androidx.recyclerview.widget.LinearLayoutManager
import coil.Coil
import coil.ImageLoader import coil.ImageLoader
import coil.request.LoadRequest import coil.request.LoadRequest
import coil.request.RequestDisposable import coil.request.RequestDisposable
@ -66,11 +67,7 @@ class CoilRecyclerViewSample : MarkwonRecyclerViewSample() {
disposable.dispose() disposable.dispose()
} }
}, },
ImageLoader.Builder(context) Coil.imageLoader(context)))
.okHttpClient(OkHttpClient())
// this line of code makes unit tests fail
// .placeholder(R.drawable.ic_image_gray_24dp)
.build()))
.build() .build()
val adapter = MarkwonAdapter.createTextViewIsRoot(R.layout.adapter_node) val adapter = MarkwonAdapter.createTextViewIsRoot(R.layout.adapter_node)