the-btfash-foundation/Markwon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix re-use of render-props for visitor

Browse Source
This commit is contained in:
Dimitry Ivanov 2019-10-15 21:28:07 +03:00
parent 204b803245
commit b22a840dbe
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -1,5 +1,10 @@
# Changelog
# 4.1.2-SNAPSHOT
* Do not re-use RenderProps when creating a new visitor (fixes [#171])
[#171]: https://github.com/noties/Markwon/issues/171
# 4.1.1
* `markwon-ext-tables`: fix padding between subsequent table blocks ([#159])
* `markwon-images`: print a single warning instead full stacktrace in case when SVG or GIF

6
markwon-core/src/main/java/io/noties/markwon/MarkwonBuilderImpl.java
View File

@ -102,13 +102,11 @@ class MarkwonBuilderImpl implements Markwon.Builder {
themeBuilder.build(),
spanFactoryBuilder.build());
final RenderProps renderProps = new RenderPropsImpl();
// @since 4.1.1
// @since 4.1.2 - do not reuse render-props (each render call should have own render-props)
final MarkwonVisitorFactory visitorFactory = MarkwonVisitorFactory.create(
visitorBuilder,
configuration,
renderProps);
configuration);
return new MarkwonImpl(
bufferType,

5
markwon-core/src/main/java/io/noties/markwon/MarkwonVisitorFactory.java
View File

@ -13,13 +13,12 @@ abstract class MarkwonVisitorFactory {
@NonNull
static MarkwonVisitorFactory create(
@NonNull final MarkwonVisitorImpl.Builder builder,
@NonNull final MarkwonConfiguration configuration,
@NonNull final RenderProps renderProps) {
@NonNull final MarkwonConfiguration configuration) {
return new MarkwonVisitorFactory() {
@NonNull
@Override
MarkwonVisitor create() {
return builder.build(configuration, renderProps);
return builder.build(configuration, new RenderPropsImpl());
}
};
}