everclear
bd3172684a
Merge 5ad24449bd5e2e4f4cc1314e1369dead8e621f4c into d1fcba9bfc0a7b95bf3fd6c8abb24a8a4200f80f
2016-02-04 19:25:22 +00:00
everclear
5ad24449bd
Removed guessing numeric type from a string.
...
This type of guess work is dangerous. It could lead to the situation where input is accepted from a query string for an primary key query, but is injected into the SQL string directly.
/api/user/10
db.Find(&user, "10") // SELECT * FROM users WHERE id = 10;
/api/user/1=1
db.Find(&user, "1=1") // SELECT * FROM users WHERE "1=1";
which is equivalent to
// SELECT * FROM users
It shouldn't behave differently based on the content of the string passed to it. Especially when that has a security implication. If the user want's to pass a int, they should pass that type.
2016-02-04 19:24:38 +00:00
Jinzhu
d1fcba9bfc
Merge pull request #834 from Xiol/patch-1
...
Fix documentation for Count() function example
2016-02-04 22:35:41 +08:00
Dane
08a740db98
Fix documentation for Count() function examples
...
Count function should pass pointer to struct rather than struct.
2016-02-04 09:23:04 +00:00
Jinzhu
c7b9acefb7
Merge pull request #823 from taiyangc/readme-typo
...
Fix README typo on Related usage.
2016-01-29 14:56:44 +08:00
Eric Chen
7bb90371e9
Fix README typo on Related usage.
2016-01-26 03:14:05 -08:00
Jinzhu
9739cb853c
Merge pull request #804 from RichardKnop/feature/reflect-fieldbyname-panic-fix
...
Fixed an issue with reflect.Value.FieldByName causing panic
2016-01-18 12:02:59 +08:00
Richard Knop
50fe671928
Fixed an issue with reflect.Value.FieldByName causing panic under certain circumstances.
2016-01-17 23:18:16 +08:00
Jinzhu
211ccf4ea6
Fix using pointer value as foreign key
2016-01-16 11:37:16 +08:00
James Kong
72104c6bf0
Fixes querying with inline map when a value is nil
...
This changes the inline map query build condition to use `IS NULL`
instead of the equality operator when the provided value is `nil`.
2016-01-15 16:38:56 -08:00
Jinzhu
341d047aa7
Rollback to old Unscoped API
2016-01-12 15:27:25 +08:00
Jinzhu
43e9035dad
Fix Association Count with Soft Delete
2016-01-12 13:56:41 +08:00
Jinzhu
801a271d07
Fix Association Count
2016-01-12 12:31:05 +08:00
Jinzhu
ee48d6986c
Update README
2016-01-11 07:28:08 +08:00
Jinzhu
84942c60b8
Include tag settings when clone a StructField
2016-01-08 09:02:01 +08:00
Jinzhu
2392e2a33e
Merge pull request #788 from jcscottiii/fix_polymorphic_test
...
Fix polymorphic test
2016-01-06 23:57:18 +08:00
James C. Scott
195d5993b3
Fix polymorphic test
...
One assertion comment says look for association with dog but the code
still uses cat. This aligns the code to now look at the association of
the dog.
2016-01-06 10:34:42 -05:00
Jinzhu
2f7811c55f
Merge pull request #787 from dolmen/patch-1
...
README: fix typo
2016-01-06 17:41:57 +08:00
Olivier Mengué
27df9104ed
README: fix typo
...
Fix typo in has-one example.
2016-01-06 10:18:23 +01:00
Jinzhu
5e23d7013e
Merge pull request #782 from fengjh/fixes-add-foreign-key-bug
...
Fixes unexpected keyname bug in addForeignKey function
2016-01-05 17:23:25 +08:00
Hui
c66995df3a
Fixes wrong number of args for format in Sprintf call bug in addForeignKey function
2016-01-05 17:02:47 +08:00
Jinzhu
3a9367612e
Port changes made in PR #652
2016-01-05 08:34:17 +08:00
Jinzhu
e60acad62a
include join table name in where conditions to avoid ambiguous column name
2016-01-05 08:05:45 +08:00
Jinzhu
ec0aa10bf2
Fix set scanner to a Field
2016-01-04 21:49:04 +08:00
Jinzhu
be45d8312e
Create index automatically when create table
2016-01-04 19:22:42 +08:00
Jinzhu
d1892d3177
Support poiner of Scanner
2016-01-04 18:42:47 +08:00
Jinzhu
f330da219c
Merge pull request #779 from shenli/master
...
scope: Catch error for db.Commit()
2016-01-04 17:59:15 +08:00
shenli
499b5b7615
scope: Catch error for db.Commit()
2016-01-04 13:32:35 +08:00
Jinzhu
4c52351b3e
Add more tests for belongs to relations with partial customized foreign keys
2016-01-04 12:29:57 +08:00
Jinzhu
8aa7b475d4
Add more tests for one to many relations with customized foreign keys
2016-01-04 12:23:24 +08:00
Jinzhu
28d1eb474b
Add test case for one to one relation with customized foreign keys
2016-01-04 08:46:03 +08:00
Jinzhu
d87a960248
Test many to many relation with customized column
2016-01-04 08:26:02 +08:00
Jinzhu
caeb4040f2
Fix use []byte as condtions
2016-01-03 20:29:46 +08:00
Jinzhu
d7237be63c
Support poiner of time
2016-01-03 20:27:08 +08:00
Jinzhu
52ac75a29a
Use []byte as condtions
2016-01-03 20:23:37 +08:00
Jinzhu
1b1dbc0fab
Respect customized sql tag when create join table
2016-01-03 19:47:48 +08:00
Jinzhu
b59eaf526e
Set Error to Association when some error happend
2016-01-03 17:52:16 +08:00
Jinzhu
2e949b02ae
Merge pull request #774 from jinzhu/get_model_struct
...
Refactor build model struct & relationships
2016-01-03 17:23:23 +08:00
Jinzhu
aa55bd3fd2
Add more tests for customized foreign keys for many2many relations
2016-01-03 17:20:24 +08:00
Jinzhu
b907500a47
Add test for many2many relations with customized foreign keys
2016-01-03 16:18:51 +08:00
Jinzhu
0f5055471a
Keep refactoring get model struct
2016-01-03 15:56:32 +08:00
Jinzhu
f53af2a236
Don't preload if has any error
2016-01-03 14:21:21 +08:00
Jinzhu
8a0c77e5fc
Fix all tests for GetModelStruct
2016-01-03 14:16:58 +08:00
Jinzhu
4bc06a21c1
Refactor GetModelStruct
2016-01-03 14:04:59 +08:00
Jinzhu
6a5a2dbc55
Refactor GetModelStruct
2016-01-03 13:10:17 +08:00
Jinzhu
4e45e6dc2d
Use field.TagSettings
2016-01-03 10:00:18 +08:00
Jinzhu
19b85b1f17
Compatible with both gorm, sql tag
2016-01-03 09:52:27 +08:00
Jinzhu
5d2b9bfe34
Refactor GetModelStruct
2016-01-03 09:46:07 +08:00
Jinzhu
9455215e61
Add association tests for composite primary key
2015-12-31 11:17:10 +08:00
Jinzhu
934e97b018
Don't need NOT IN conditions when there are no primary keys found
2015-12-30 15:34:56 +08:00