image-coil, change api dependency to base

This commit is contained in:
Dimitry Ivanov 2020-08-13 17:48:44 +03:00
parent d26da7c1a0
commit 55e640af9c
5 changed files with 18 additions and 3 deletions

View File

@ -2,6 +2,9 @@
# SNAPSHOT # SNAPSHOT
#### Changed
* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency)
#### Fixed #### Fixed
* `image-coil` - deliver image result if it loaded before request disposable is created ([#272]) * `image-coil` - deliver image result if it loaded before request disposable is created ([#272])
* `ext-tables` - fix column width rounding issue * `ext-tables` - fix column width rounding issue

View File

@ -159,6 +159,7 @@ dependencies {
implementation it['debug'] implementation it['debug']
implementation it['android-svg'] implementation it['android-svg']
implementation it['android-gif-impl'] implementation it['android-gif-impl']
implementation it['coil']
} }
deps['test'].with { deps['test'].with {

View File

@ -58,6 +58,7 @@ ext {
final def commonMarkVersion = '0.13.0' final def commonMarkVersion = '0.13.0'
final def daggerVersion = '2.10' final def daggerVersion = '2.10'
final def coilVersion = '0.10.1'
// please note that `pl.droidsonroids.gif:android-gif-drawable:1.2.15` is used due to the minimum // please note that `pl.droidsonroids.gif:android-gif-drawable:1.2.15` is used due to the minimum
// api level mismatch that Markwon supports (16) and later versions of AndroidGifDrawable (17). // api level mismatch that Markwon supports (16) and later versions of AndroidGifDrawable (17).
@ -86,7 +87,8 @@ ext {
'dagger' : "com.google.dagger:dagger:$daggerVersion", 'dagger' : "com.google.dagger:dagger:$daggerVersion",
'picasso' : 'com.squareup.picasso:picasso:2.71828', 'picasso' : 'com.squareup.picasso:picasso:2.71828',
'glide' : 'com.github.bumptech.glide:glide:4.9.0', 'glide' : 'com.github.bumptech.glide:glide:4.9.0',
'coil' : 'io.coil-kt:coil:0.10.1', 'coil' : "io.coil-kt:coil:$coilVersion",
'coil-base' : "io.coil-kt:coil-base:$coilVersion",
'ix-java' : 'com.github.akarnokd:ixjava:1.0.0', 'ix-java' : 'com.github.akarnokd:ixjava:1.0.0',
'gson' : 'com.google.code.gson:gson:2.8.6', 'gson' : 'com.google.code.gson:gson:2.8.6',
'commons-io' : 'commons-io:commons-io:2.6' 'commons-io' : 'commons-io:commons-io:2.6'

View File

@ -2,7 +2,7 @@
<MavenBadge4 :artifact="'image-coil'" /> <MavenBadge4 :artifact="'image-coil'" />
Image loading based on `Coil` library Image loading based on `Coil` library.
```kotlin ```kotlin
val markwon = Markwon.builder(context) val markwon = Markwon.builder(context)
@ -33,3 +33,8 @@ val markwon = Markwon.builder(context)
}, customImageLoader)) }, customImageLoader))
.build() .build()
``` ```
:::warning
In order to use the `CoilImagesPlugin.create(Context)` factory method your
app must have **explicit** dependency on `coil` library
:::

View File

@ -15,7 +15,11 @@ android {
dependencies { dependencies {
api project(':markwon-core') api project(':markwon-core')
api deps['coil']
// @since $SNAPSHOT; declare `coil-base` as api dependency (would require users
// to have explicit coil dependency)
api deps['coil-base']
compileOnly deps['coil']
} }
registerArtifact(this) registerArtifact(this)