the-btfash-foundation/Markwon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare 4.5.1 release

Browse Source
This commit is contained in:
Dimitry Ivanov 2020-08-13 18:59:30 +03:00
parent 854fa744c7
commit 602891566d
3 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@ -1,15 +1,17 @@
# Changelog # Changelog
# SNAPSHOT # 4.5.1
#### Changed #### Changed
* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) * `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) ([#274])
#### Fixed #### Fixed
* `image-coil` - deliver image result if it loaded before request disposable is created ([#272]) * `image-coil` - deliver image result if it loaded before request disposable is created ([#272])
* `ext-tables` - fix column width rounding issue * `ext-tables` - fix column width rounding issue
[#272]: https://github.com/noties/Markwon/issues/272 [#272]: https://github.com/noties/Markwon/issues/272
[#274]: https://github.com/noties/Markwon/issues/274
# 4.5.0 # 4.5.0

2
markwon-image-coil/build.gradle
View File

@ -16,7 +16,7 @@ android {
dependencies { dependencies {
api project(':markwon-core') api project(':markwon-core')
// @since $SNAPSHOT; declare `coil-base` as api dependency (would require users // @since 4.5.1 declare `coil-base` as api dependency (would require users
// to have explicit coil dependency) // to have explicit coil dependency)
api deps['coil-base'] api deps['coil-base']
compileOnly deps['coil'] compileOnly deps['coil']

4
markwon-image-coil/src/main/java/io/noties/markwon/image/coil/CoilImagesPlugin.java
View File

@ -130,7 +130,7 @@ public class CoilImagesPlugin extends AbstractMarkwonPlugin {
final LoadRequest request = coilStore.load(drawable).newBuilder() final LoadRequest request = coilStore.load(drawable).newBuilder()
.target(target) .target(target)
.build(); .build();
// @since $SNAPSHOT; execute can return result _before_ disposable is created, // @since 4.5.1 execute can return result _before_ disposable is created,
// thus `execute` would finish before we put disposable in cache (and thus result is // thus `execute` would finish before we put disposable in cache (and thus result is
// not delivered) // not delivered)
final RequestDisposable disposable = imageLoader.execute(request); final RequestDisposable disposable = imageLoader.execute(request);
@ -168,7 +168,7 @@ public class CoilImagesPlugin extends AbstractMarkwonPlugin {
@Override @Override
public void onSuccess(@NonNull Drawable loadedDrawable) { public void onSuccess(@NonNull Drawable loadedDrawable) {
// @since $SNAPSHOT; check finished flag (result can be delivered _before_ disposable is created) // @since 4.5.1 check finished flag (result can be delivered _before_ disposable is created)
if (cache.remove(drawable) != null if (cache.remove(drawable) != null
|| !loaded.get()) { || !loaded.get()) {
// mark // mark